Build #167 (Jan 12, 2011 4:00:23 AM)

1. use SQLite3::VERSION rather than the deprecated class (detail)
2. Always return decimal average of integer fields (detail)
3. adding to_d to BigDecimal (detail)
4. only use one array when collecting split up queries (detail)
5. Fix polymorphic belongs_to associationproxy raising errors when loading target. (detail)
6. html_safe.to_str makes no sense (detail)
7. avoid splatting arrays by using concat (detail)
8. Correctly indent the bullet points under 'One-to-one associations', so that the lines are not broken in the generated rdoc html (detail)
9. For a singular association, it should be build_association, rather than association.build (as association may be nil) (detail)
10. Remove incorrect documentation about build_assoc on has_one. This is proven, for example, by test_successful_build_association in has_one_associations_test.rb (detail)
11. Return value is irrelevant here as the RHS of the assignment is always returned by methods ending in '=' (detail)
12. has_one should always remove the old record (properly), even if not saving the new record, so we don't get the database into a pickle (detail)
13. Enable the sqlite3 in-memory test connection to work (detail)
14. Have a separate test connection directory for sqlite3 in-memory so that the tests can be run without having to specifically rename the connection file (which then causes git to pick up the changes) (detail)
15. When assigning a has_one, if the existing record fails to be removed from the association, raise an error (detail)
16. When assigning a has_one, if the new record fails to save, raise an error (detail)
17. SQLite3 has supported savepoints since version 3.6.8, we should use this! (detail)
18. In a number of places in the tests, we only need to turn off transactional fixtures when the DB does not support savepoints. This speeds the test run up by about 8-9% on my computer, when running rake test_sqlite3_mem :) (detail)
19. When assigning a has_one, if anything fails, the assignment should be rolled back entirely (detail)
20. Raise ActiveRecord::RecordNotSaved if an AssociationCollection fails to be replaced (detail)
21. Document the recent changes to association assignment (detail)
22. find_target can be inherited (detail)
23. DRY up the code which instantiates the association proxy (detail)
24. We can use the association_proxy method directly in HasOneThroughAssociation now (detail)
25. Get rid of set_association_target and association_loaded? as the parts of the code that need that can now just use association_proxy(:name).loaded?/target= (detail)
26. It's not necessary to pass the association proxy class around now (detail)
27. Refactor the code for singular association constructors. This will allow me to define a create_association! method in a minute. (detail)
28. Support for create_association! for has_one associations (detail)
29. test_with_polymorphic_and_condition works without the conditions methods in BelongsToPolymorphicAssociation because the conditions are added straight to the association_scope as of a few days ago (detail)
30. lazily instantiate AR objects in order to avoid NoMethodErrors (detail)
31. kill unused variable warnings (detail)
32. use underlying _read_attribute method rather than causing NoMethodErrors (detail)
33. adding a test for no method error (detail)

Started by timer

• origin/master